Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.11.0 #147

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2023

Bumps github.com/onsi/ginkgo/v2 from 2.9.2 to 2.11.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.11.0

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]

v2.10.0

2.10.0

Features

  • feat(ginkgo/generators): add --tags flag (#1216) [a782a77] adds a new --tags flag to ginkgo generate

Fixes

  • Fix broken link of MIGRATING_TO_V2.md (#1217) [548d78e]

Maintenance

  • Bump golang.org/x/tools from 0.9.1 to 0.9.3 (#1215) [2b76a5e]

v2.9.7

2.9.7

Fixes

  • fix race when multiple defercleanups are called in goroutines [07fc3a0]

v2.9.6

2.9.6

Fixes

  • fix: create parent directory before report files (#1212) [0ac65de]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.6 to 1.27.7 (#1202) [3e39231]

v2.9.5

2.9.5

... (truncated)

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]

2.10.0

Features

  • feat(ginkgo/generators): add --tags flag (#1216) [a782a77] adds a new --tags flag to ginkgo generate

Fixes

  • Fix broken link of MIGRATING_TO_V2.md (#1217) [548d78e]

Maintenance

  • Bump golang.org/x/tools from 0.9.1 to 0.9.3 (#1215) [2b76a5e]

2.9.7

Fixes

  • fix race when multiple defercleanups are called in goroutines [07fc3a0]

2.9.6

Fixes

  • fix: create parent directory before report files (#1212) [0ac65de]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.6 to 1.27.7 (#1202) [3e39231]

2.9.5

Fixes

  • ensure the correct deterministic sort order is produced when ordered specs are generated by a helper function [7fa0b6b]

Maintenance

  • fix generators link (#1200) [9f9d8b9]

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 19, 2023
@KPostOffice
Copy link
Collaborator

/hold

@anishasthana
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 3, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@anishasthana
Copy link
Member

@dependabot recreate

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.2 to 2.11.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.9.2...v2.11.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.11.0 branch from 8c0ca0e to b1069ac Compare August 3, 2023 20:00
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Given that all the tests are passing, I feel good merging this in.

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 226a560 into main Aug 4, 2023
7 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.11.0 branch August 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants