Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLM install and upgrade PR check for CodeFlare stack #162

Merged
merged 1 commit into from
Jul 12, 2023
Merged

OLM install and upgrade PR check for CodeFlare stack #162

merged 1 commit into from
Jul 12, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 4, 2023

Fixes #159

Depends on #136

/cc @astefanutti

@openshift-ci openshift-ci bot requested a review from astefanutti July 4, 2023 14:25
@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sutaakar
Copy link
Contributor Author

sutaakar commented Jul 4, 2023

/test all

@sutaakar sutaakar force-pushed the olm-tests branch 3 times, most recently from 95c5c03 to 7129092 Compare July 11, 2023 06:57
@sutaakar sutaakar marked this pull request as ready for review July 11, 2023 07:42
ChristianZaccaria
ChristianZaccaria approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2023
anishasthana
anishasthana reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

KPostOffice
KPostOffice reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I'll run through the action myself tomorrow morning. Thanks @sutaakar !

.github/workflows/olm_tests.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
.github/workflows/olm_tests.yaml Outdated Show resolved Hide resolved
.github/workflows/olm_tests.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Jul 12, 2023
KPostOffice
KPostOffice requested changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment

.github/workflows/olm_tests.yaml Outdated Show resolved Hide resolved
@sutaakar sutaakar force-pushed the olm-tests branch 2 times, most recently from 7b1bcab to fb2102c Compare July 12, 2023 15:36
@ChristianZaccaria
Copy link
Contributor

I pushed the changes in this PR to my fork and the OLM Install and Upgrade / kubernetes (pull_request) Action failed. I believe you said this was expected. What do you think? @sutaakar

My fork: #182

@sutaakar
Copy link
Contributor Author

@ChristianZaccaria the test failure is unrelated to secrets experiment, it is caused by too low timeout (already raised timeout in this PR). Need to think up some other workflow for secret tests.

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9c269d0 into project-codeflare:main Jul 12, 2023
@sutaakar sutaakar deleted the olm-tests branch July 13, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana left review comments

@ChristianZaccaria ChristianZaccaria ChristianZaccaria approved these changes

@KPostOffice KPostOffice KPostOffice approved these changes

@astefanutti astefanutti Awaiting requested review from astefanutti

Assignees

@anishasthana anishasthana

@KPostOffice KPostOffice

@ChristianZaccaria ChristianZaccaria

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up OLM install and upgrade PR check for CodeFlare stack
5 participants
@sutaakar @ChristianZaccaria @anishasthana @KPostOffice @openshift-merge-robot