Fix mcad tag reference for CRDs #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream is no longer publishing release branches of the form `release-vX.Y.Z` Instead, it is publishing tags of the form `vX.Y.Z`, this commit makes it so Signed-off-by: Anish Asthana <[email protected]>
sutaakar
approved these changes
Jul 10, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream is no longer publishing release branches of the form
release-vX.Y.ZInstead, it is publishing tags of the formvX.Y.Z, this commit makes it so.I also had to do a lot of work to get the tests to pass -- the
controller-genkept failing with errors likeThe errors seem to mainly be in the
supportdirectory. I ended up just deleting all the tests...This closes #171