Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow - open a PR with changes instead of direct push #201

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 28, 2023

Issue link

Fixes #200

What changes have been made

Release workflow was altered to open a PR with code changes instead of pushing changes directly.

Verification steps

Can be verified using own fork of codeflare-operator repository.
Setup the required secrets for your fork:

  • CODEFLARE_MACHINE_ACCOUNT_TOKEN - personal access token with rights to create PRs
  • QUAY_ID, QUAY_TOKEN - credentials for Quay account to push images to
    Push changes in this PR into your repository fork on main branch.
    Manually run the workflow, provide workflow parameters pointing to your own repositories (to avoid messing with official repos).

You can see results on my fork:
https://github.com/sutaakar/codeflare-operator/actions/runs/5694084278
sutaakar#14

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 817f97e into project-codeflare:main Jul 28, 2023
4 checks passed
@sutaakar sutaakar deleted the open-pr branch July 28, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow should open a PR with changes instead of direct push
3 participants