Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client action #204

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add client action #204

merged 1 commit into from
Aug 4, 2023

Conversation

anishasthana
Copy link
Member

This PR adds github action checks for the following:

  1. Generated client
  2. Generated manifests
  3. Generated code.

This should help ensure that our artifacts are always up to date.

@openshift-ci openshift-ci bot requested a review from Maxusmusti July 31, 2023 20:14
astefanutti
astefanutti reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you feel strong about splitting everything into its own workflow. It seems grouping the those checks, together with the openshift-goimports would make their execution faster and spare resources.

.github/workflows/verify_generate_client.yaml Outdated Show resolved Hide resolved
@anishasthana
Copy link
Member Author

Do you feel strong about splitting everything into its own workflow. It seems grouping the those checks, together with the openshift-goimports would make their execution faster and spare resources.

Not strongly about it at all. I thought it might be clearer for users what is failing if it's a separate action. I can consolidate them into one.

@anishasthana
Copy link
Member Author

I'll work on consolidating into one action.

@anishasthana
Copy link
Member Author

Consolidated.

@astefanutti
Copy link
Contributor

/lgtm

We could also add a verification step that check go mod tidy induces no diff.

@openshift-ci openshift-ci bot added the lgtm label Aug 3, 2023
@openshift-ci openshift-ci bot removed the lgtm label Aug 3, 2023
tedhtchang
tedhtchang reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@tedhtchang tedhtchang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM tried here

@astefanutti
Copy link
Contributor

/lgtm

/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8bf0aab into project-codeflare:main Aug 4, 2023
4 checks passed
@anishasthana anishasthana deleted the add_client_action branch August 4, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedhtchang tedhtchang tedhtchang left review comments

@astefanutti astefanutti astefanutti left review comments

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@astefanutti astefanutti

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anishasthana @astefanutti @tedhtchang @openshift-merge-robot