Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Use Ray dashboard API to retrieve job logs #208

Merged
merged 2 commits into from
Aug 8, 2023
Merged

e2e: Use Ray dashboard API to retrieve job logs #208

merged 2 commits into from
Aug 8, 2023

Conversation

astefanutti
Copy link
Contributor

Closes #199.

@openshift-ci openshift-ci bot requested review from dimakis and jbusche August 3, 2023 09:19
@astefanutti astefanutti requested review from anishasthana and sutaakar and removed request for dimakis and jbusche August 3, 2023 09:49
anishasthana
anishasthana reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment, really.
Somewhat related, once project-codeflare/codeflare-sdk#174 is merged in we should revisit the route related test cases

@astefanutti
Copy link
Contributor Author

Just had one comment, really.
Somewhat related, once project-codeflare/codeflare-sdk#174 is merged in we should revisit the route related test cases

Yes, that should be revised as the TestMNISTRayClusterSDK test is enabled on vanilla Kubernetes.

anishasthana
anishasthana reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2023
sutaakar
sutaakar approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@anishasthana
Copy link
Member

Weird that the approved label wasn't applied.
/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit bc4b46a into project-codeflare:main Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana left review comments

@sutaakar sutaakar sutaakar approved these changes

Assignees

@sutaakar sutaakar

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests - Retrieve Ray job logs using REST API only
4 participants
@astefanutti @anishasthana @sutaakar @openshift-merge-robot