Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix - Make target with multiple recipes #220

Merged

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Aug 9, 2023

Issue link

Closes #219

What changes have been made

Changed the make target to a unique one.

Verification steps

Can now run make kind-e2e and it will create a kind cluster.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

Thanks!

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit d987823 into project-codeflare:main Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Multiple recipes for a target in Makefile
3 participants