Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SDK version, fix TestMNISTRayClusterSDK #223

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Aug 9, 2023

Release automation doesn't raise SDK version. Will address it in next PR.

Issue link

What changes have been made

Adjusted SDK version to latest release, applied changes in TestMNISTRayClusterSDK.

Verification steps

Install CodeFlare operator using OLM on OpenShift.
Install test requirements by running make setup-e2e
Run e2e tests - TestMNISTRayClusterSDK.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit b325fab into project-codeflare:main Aug 9, 2023
8 checks passed
@sutaakar sutaakar deleted the sdk-version branch August 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants