Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CODEFLARE_SDK_VERSION in GitHub release workflow #225

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Aug 9, 2023

Issue link

Fixes #224

What changes have been made

Replacing CODEFLARE_SDK_VERSION value in Makefile in release GitHub workflow.

Verification steps

Checkout this PR, push it to your fork of CodeFlare operator repo.
Run release workflow, providing own values as parameters.
Check the content of PR opened with code changes - it will contain SDK version update.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar added the testing Items related to testing label Aug 10, 2023
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 30a6812 into project-codeflare:main Aug 11, 2023
4 checks passed
@sutaakar sutaakar deleted the sdk branch August 11, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm testing Items related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust CODEFLARE_SDK_VERSION in GitHub release workflow
3 participants