Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test support: Return list of AppWrappers #268

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Sep 1, 2023

Also adding clients for image operations and dynamic client.

Issue link

N/A

What changes have been made

Adding support functionality for opendatahub-io/distributed-workloads#103
Adding a function to return AppWrappers based on name prefix, also creation of temporary file with content.

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar force-pushed the appwrapper branch 2 times, most recently from 8317d77 to c577ae9 Compare September 5, 2023 13:12
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@sutaakar sutaakar marked this pull request as ready for review September 5, 2023 13:47
@sutaakar sutaakar changed the title Test support: Return AppWrappers based on prefix Test support: Return list of AppWrappers Sep 5, 2023
@sutaakar
Copy link
Contributor Author

sutaakar commented Sep 6, 2023

Self approving as nobody else reacts and I need this merged for follow up PR
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4ae9e8f into project-codeflare:main Sep 6, 2023
8 checks passed
@sutaakar sutaakar deleted the appwrapper branch September 6, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants