Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: addition of rbac needed for instascale controller #304

Merged
merged 4 commits into from
Sep 27, 2023
Merged

refactor: addition of rbac needed for instascale controller #304

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c2317d
refactor: addition of rbac needed for instascale controller
dimakis Sep 22, 2023
b3ae92b
refactor: remove duplicate permissions and remove wildcard for machin…
dimakis Sep 25, 2023
95b9201
refactor: limit resources for machine.openshift.io api group
dimakis Sep 25, 2023
ae38143
refactor: removes unneccessary permissions
dimakis Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 4 additions & 43 deletions config/rbac/instascale_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ metadata:
creationTimestamp: null
name: instascale-role
rules:
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- apiGroups:
- ""
resources:
Expand All @@ -22,20 +16,10 @@ rules:
- update
- apiGroups:
- ""
resourceNames:
- instascale-ocm-secret
resources:
- secrets
verbs:
- get
- apiGroups:
- apps
resources:
- deployments
verbs:
- get
- list
- watch
- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -65,19 +49,10 @@ rules:
- apiGroups:
- machine.openshift.io
resources:
- '*'
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers
- controlplanemachinesets
- machinehealthchecks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two resources really used by InstaScale?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have specified I've pushed this as myself and mark are testing which are actually used and what we can cut away.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if you know off hand...that would save us some time?

I was doubtful that we used those TBH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that InstaScale only uses the Machine and MachineSet APIs but better double checking.

- machines
- machinesets
verbs:
- create
- delete
Expand All @@ -86,17 +61,3 @@ rules:
- patch
- update
- watch
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers/finalizers
verbs:
- update
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers/status
verbs:
- get
- patch
- update
Loading