Update compute resources to account for MCAD and InstaScale #305
Conversation
| requests: | ||
| cpu: 10m | ||
| memory: 64Mi | ||
| cpu: "1" |
There was a problem hiding this comment.
1 CPU is quite high for two controllers, is it really needed?
There was a problem hiding this comment.
Yes, I've been reluctant, given our current CI environment is short on CPU, but MCAD has not the reputation to be lightweight, and its tests assume 2 CPUs. It may explain why no CPU requirements were specified for MCAD in the previous operator design.
I also think it may not be a good practice to drive these requirements by the limitation of our current CI environment. So they may have to be configured, depending on the environment.
There was a problem hiding this comment.
Thinking whether it may have sense to reduce the request value.
This helps with resource usage for not intensive cases, while keeping the limit high enough. On the other side it can affect pod eviction order.
There was a problem hiding this comment.
I'd be inclined to have MCAD configured with the guaranteed QoS class, and with enough resources, so it performs acceptably by default.
With that in mind, I've added the extra test configuration so it can still run within the limited resources of GH Actions runners.
|
/assign @anishasthana @sutaakar @KPostOffice |
|
@astefanutti, It's interesting... I first tried control runs on a default |
|
I guess the MCAD is not limited by resources but rather by something internal. |
@jbusche the resource requests / limits must be set in the Subscription, not the CSV, otherwise they'll get overwritten. One way to make sure, is to modify the Subscription and check the Deployment gets eventually updated accordingly. |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimakis, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following up #216, this PR update the operator compute resources so it better accounts for both MCAD and InstaScale controllers requirements.
It configures the resources so that the operator is assigned with the guaranteed QoS class, and with enough resources, so it performs acceptably by default.
Closes #280.