Generate AppWrapper name in tests to provide unique workloads #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sutaakar
force-pushed
the
context
branch
12 times, most recently
from
00a2cae
to
4de87c0
Compare
sutaakar
changed the title
sutaakar
requested review from
dgrove-oss
and removed request for
dimakis and
ChristianZaccaria
sutaakar
changed the title
|
We haven't considered wrapping resources that use GenerateName. Looking to see if it is easily fixable... |
|
I updated #588 to pick up AppWrapper 0.21.1 which has the fix for generateNames. Not sure how best to merge the 2 PRs |
|
Will merge your PR first, then update this PR to use generated names for resources |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
N/A
What changes have been made
Generating AppWrapper name to make sure that AppWrappers are unique to avoid reconciliation issues.
Verification steps
PR checks pass reliably.
Checks