keepin it DRY with a helper function 4 owner ref #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Aug 7, 2024
pkg/controllers/support.go
Outdated
| @@ -212,3 +200,12 @@ func (l logSink) WithName(name string) logr.LogSink { | |||
| func FilteredLogger(logger logr.Logger) logr.Logger { | |||
| return logger.WithSink(logSink{logger.GetSink()}) | |||
| } | |||
|
|
|||
| func OwnerRefFromCluster(cluster *rayv1.RayCluster) *v1.OwnerReferenceApplyConfiguration { | |||
There was a problem hiding this comment.
nit: ownerRefForRayCluster
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
refactor-owner-ref
branch
from
23b8b3c
to
1b781d0
Compare
astefanutti
approved these changes
Aug 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 280b766
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes have been made
I created a helper function for creating OwnerReferences from RayClusters
Checks