Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update appwrappers to v0.24.0 #611

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dgrove-oss
Copy link
Collaborator

Features

  • Upgrade to Kueue 0.8.0
  • Use Patch operations to update AppWrapper.Status
  • Inject AppWrapper finalizer in WebHook

Bugs and Regressions

  • Get dev mode (make run) working again
  • account for all covered resources when a node is cordoned

Other Changes

  • Logging improvements for development/debugging
  • Upgrade to Kind v0.24.0
  • Unit test improvement
  • add failing job with retry to end-to-end tests
  • improve e2e testing of failures
  • need non-zero reset pause to reliably detect Resetting phase

Full Changelog: project-codeflare/appwrapper@v0.23.0...v0.24.0

Features
* Upgrade to Kueue 0.8.0
* Use Patch operations to update AppWrapper.Status
* Inject AppWrapper finalizer in WebHook

Bugs and Regressions
* Get dev mode (make run) working again
* account for all covered resources when a node is cordoned

Other Changes
* Logging improvements for development/debugging
* Upgrade to Kind v0.24.0
* Unit test improvement
* add failing job with retry to end-to-end tests
* improve e2e testing of failures
* need non-zero reset pause to reliably detect Resetting phase

Full Changelog: project-codeflare/appwrapper@v0.23.0...v0.24.0
go.mod Show resolved Hide resolved
Copy link

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dgrove-oss
Copy link
Collaborator Author

Needs @varshaprasad96 to /approve again (she wasn't in the owners file for the initial /approve).

Copy link

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96 varshaprasad96 merged commit 8057522 into project-codeflare:main Aug 30, 2024
8 checks passed
@dgrove-oss dgrove-oss deleted the awbump branch August 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants