Skip to content

Commit

Permalink
Fix warning from pytest and increase pretty_print coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristianZaccaria authored and openshift-merge-bot[bot] committed Mar 14, 2024
1 parent 5422936 commit 0c014f1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,3 @@ markers = [
"kind",
"openshift"
]
timeout = 900
16 changes: 4 additions & 12 deletions src/codeflare_sdk/utils/pretty_print.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,11 @@ def print_cluster_status(cluster: RayCluster):
)
name = cluster.name
dashboard = cluster.dashboard
# owned = bool(cluster["userOwned"])
owned = True

#'table0' to display the cluster name, status, url, and dashboard link
table0 = Table(box=None, show_header=False)
if owned:
table0.add_row("[white on green][bold]Name")
else:
table0.add_row("")

table0.add_row("[white on green][bold]Name")
table0.add_row("[bold underline]" + name, status)
table0.add_row()
# fixme harcded to default for now
Expand Down Expand Up @@ -119,15 +115,11 @@ def print_clusters(clusters: List[RayCluster]):
memory = str(cluster.worker_mem_min) + "~" + str(cluster.worker_mem_max)
cpu = str(cluster.worker_cpu)
gpu = str(cluster.worker_gpu)
# owned = bool(cluster["userOwned"])
owned = True

#'table0' to display the cluster name, status, url, and dashboard link
table0 = Table(box=None, show_header=False)
if owned:
table0.add_row("[white on green][bold]Name")
else:
table0.add_row("")

table0.add_row("[white on green][bold]Name")
table0.add_row("[bold underline]" + name, status)
table0.add_row()
# fixme harcded to default for now
Expand Down

0 comments on commit 0c014f1

Please sign in to comment.