Skip to content

Commit

Permalink
This should work
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristianZaccaria committed Oct 24, 2024
1 parent 13658b8 commit 17e6487
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ updates:
ignore:
- dependency-name: "*"
update-types: ["version-update:semver-patch"]
open-pull-requests-limit: 4
open-pull-requests-limit: 1
labels:
- "dependabot"
- "test-guided-notebooks"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/dependabot-labeler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ name: Dependabot Labeler
on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]

# TODO: CHANGE BACK
jobs:
add-approve-lgtm-label:
if: ${{ github.actor == 'dependabot[bot]' && contains(github.event.pull_request.labels.*.name, 'dependabot') }}
if: ${{ contains(github.event.pull_request.labels.*.name, 'dependabot') }}
runs-on: ubuntu-latest

# Permission required to edit a PR
Expand All @@ -24,4 +24,4 @@ jobs:
run: |
gh pr edit ${{ github.event.pull_request.number }} --add-label "lgtm" --add-label "approved"
env:
GITHUB_TOKEN: ${{ secrets.CODEFLARE_MACHINE_ACCOUNT_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GH_CLI_TOKEN }}
12 changes: 0 additions & 12 deletions .github/workflows/e2e_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: e2e

on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]
branches:
- main
- 'release-*'
Expand All @@ -12,16 +11,6 @@ on:
- '**.adoc'
- '**.md'
- 'LICENSE'
push:
branches:
- main
- 'release-*'
paths-ignore:
- 'docs/**'
- '**.adoc'
- '**.md'
- 'LICENSE'
merge_group:

concurrency:
group: ${{ github.head_ref }}-${{ github.workflow }}
Expand All @@ -32,7 +21,6 @@ env:

jobs:
kubernetes:
if: contains(github.event.pull_request.labels.*.name, 'e2e') || github.event_name == 'merge_group'
runs-on: ubuntu-20.04-4core-gpu

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/guided_notebook_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:

jobs:
verify-0_basic_ray:
if: contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks')
if: ${{ contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') }}
runs-on: ubuntu-20.04-4core

steps:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/pre-commit.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
name: Pre-commit
on:
push:
branches:
- '**'
tags-ignore:
- 'v*'
pull_request:
workflow_dispatch:
merge_group:

jobs:
precommit:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui_notebooks_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:

jobs:
verify-3_widget_example:
if: contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') || contains(github.event.pull_request.labels.*.name, 'test-ui-notebooks')
if: ${{ contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') || contains(github.event.pull_request.labels.*.name, 'test-ui-notebooks') }}
runs-on: ubuntu-20.04-4core

steps:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
name: Python Tests

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
merge_group:

jobs:
unit-tests:
Expand Down

0 comments on commit 17e6487

Please sign in to comment.