Skip to content

Commit

Permalink
Fix for the odh-notebook-sync workflow.
Browse files Browse the repository at this point in the history
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support
was broken. Apart from that - the array initialization was fixed and the
link to this workflow is added to the raised PR description.
  • Loading branch information
jstourac authored and openshift-merge-bot[bot] committed Sep 30, 2024
1 parent 52f20a4 commit bdedaff
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/odh-notebooks-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ jobs:
- name: Update Pipfiles in accordance with Codeflare-SDK latest release
run: |
package_name=codeflare-sdk
available_python_versions=("3.9", "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
available_python_versions=("3.9" "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
install_package_using_pipenv(){
# args allow custom names for Pipfile and Pipfile.lock
if $# -eq 2; then
mv $1 Pipfile
mv $2 Pipfile.lock
if [ $# -eq 2 ]; then
mv "${1}" Pipfile
mv "${2}" Pipfile.lock
fi
if ! pipenv install ${package_name}~="${CODEFLARE_RELEASE_VERSION}"; then
echo "Failed to install ${package_name} with version ${CODEFLARE_RELEASE_VERSION} in $dir"
Expand All @@ -76,9 +76,9 @@ jobs:
echo "Failed to remove virtual environment"
exit 1
fi
if $# -eq 2; then
mv Pipfile $1
mv Pipfile.lock $2
if [ $# -eq 2 ]; then
mv Pipfile "${1}"
mv Pipfile.lock "${2}"
fi
}
# Get the list of available versions for the package
Expand Down Expand Up @@ -153,6 +153,6 @@ jobs:
env:
pr_title: "[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release ${{ env.CODEFLARE_RELEASE_VERSION }}"
pr_body: |
:rocket: This is an automated Pull Request.
:rocket: This is an automated Pull Request generated by [odh-notebooks-sync.yml](https://github.com/project-codeflare/codeflare-sdk/blob/main/.github/workflows/odh-notebooks-sync.yml) workflow.
This PR updates the `Pipfile` to sync with latest Codeflare-SDK release.

0 comments on commit bdedaff

Please sign in to comment.