Skip to content

Commit

Permalink
Update cluster configuration to increase worker memory and remove ray…
Browse files Browse the repository at this point in the history
…-img input parameter given in cluster configuration for e2e tests
  • Loading branch information
abhijeet-dhumal authored and openshift-merge-bot[bot] committed Jul 16, 2024
1 parent c46efe2 commit e7a45ba
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 18 deletions.
5 changes: 1 addition & 4 deletions tests/e2e/local_interactive_sdk_kind_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ def test_local_interactives_nvidia_gpu(self):
def run_local_interactives(
self, gpu_resource_name="nvidia.com/gpu", number_of_gpus=0
):
ray_image = get_ray_image()

cluster_name = "test-ray-cluster-li"

cluster = Cluster(
Expand All @@ -51,9 +49,8 @@ def run_local_interactives(
worker_cpu_requests="500m",
worker_cpu_limits=1,
worker_memory_requests=1,
worker_memory_limits=2,
worker_memory_limits=4,
worker_extended_resource_requests={gpu_resource_name: number_of_gpus},
image=ray_image,
write_to_file=True,
verify_tls=False,
)
Expand Down
5 changes: 1 addition & 4 deletions tests/e2e/local_interactive_sdk_oauth_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def test_local_interactives(self):
self.run_local_interactives()

def run_local_interactives(self):
ray_image = get_ray_image()

auth = TokenAuthentication(
token=run_oc_command(["whoami", "--show-token=true"]),
server=run_oc_command(["whoami", "--show-server=true"]),
Expand All @@ -46,9 +44,8 @@ def run_local_interactives(self):
num_workers=1,
worker_cpu_requests=1,
worker_cpu_limits=1,
worker_memory_requests=4,
worker_memory_requests=1,
worker_memory_limits=4,
image=ray_image,
verify_tls=False,
)
)
Expand Down
3 changes: 0 additions & 3 deletions tests/e2e/mnist_raycluster_sdk_aw_kind_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ def test_mnist_ray_cluster_sdk_kind_nvidia_gpu(self):
def run_mnist_raycluster_sdk_kind(
self, accelerator, gpu_resource_name="nvidia.com/gpu", number_of_gpus=0
):
ray_image = get_ray_image()

cluster = Cluster(
ClusterConfiguration(
name="mnist",
Expand All @@ -50,7 +48,6 @@ def run_mnist_raycluster_sdk_kind(
worker_memory_requests=1,
worker_memory_limits=4,
worker_extended_resource_requests={gpu_resource_name: number_of_gpus},
image=ray_image,
write_to_file=True,
verify_tls=False,
appwrapper=True,
Expand Down
3 changes: 0 additions & 3 deletions tests/e2e/mnist_raycluster_sdk_kind_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ def test_mnist_ray_cluster_sdk_kind_nvidia_gpu(self):
def run_mnist_raycluster_sdk_kind(
self, accelerator, gpu_resource_name="nvidia.com/gpu", number_of_gpus=0
):
ray_image = get_ray_image()

cluster = Cluster(
ClusterConfiguration(
name="mnist",
Expand All @@ -51,7 +49,6 @@ def run_mnist_raycluster_sdk_kind(
worker_memory_requests=1,
worker_memory_limits=4,
worker_extended_resource_requests={gpu_resource_name: number_of_gpus},
image=ray_image,
write_to_file=True,
verify_tls=False,
)
Expand Down
5 changes: 1 addition & 4 deletions tests/e2e/mnist_raycluster_sdk_oauth_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def test_mnist_ray_cluster_sdk_auth(self):
self.run_mnist_raycluster_sdk_oauth()

def run_mnist_raycluster_sdk_oauth(self):
ray_image = get_ray_image()

auth = TokenAuthentication(
token=run_oc_command(["whoami", "--show-token=true"]),
server=run_oc_command(["whoami", "--show-server=true"]),
Expand All @@ -47,8 +45,7 @@ def run_mnist_raycluster_sdk_oauth(self):
worker_cpu_requests="500m",
worker_cpu_limits=1,
worker_memory_requests=1,
worker_memory_limits=2,
image=ray_image,
worker_memory_limits=4,
write_to_file=True,
verify_tls=False,
)
Expand Down

0 comments on commit e7a45ba

Please sign in to comment.