Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ray version in default template and code references #379

Merged
merged 1 commit into from
Oct 10, 2023
Merged

update ray version in default template and code references #379

merged 1 commit into from
Oct 10, 2023

Conversation

KPostOffice
Copy link
Collaborator

@KPostOffice KPostOffice commented Oct 10, 2023 •
edited by Maxusmusti
Loading

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Maxusmusti
Maxusmusti requested changes Oct 10, 2023
View reviewed changes
tests/unit_test.py Outdated Show resolved Hide resolved
Maxusmusti
Maxusmusti reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
anishasthana
anishasthana reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dimakis
dimakis reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

custom-nb-image/Dockerfile Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
Maxusmusti
Maxusmusti approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Maxusmusti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 7f4710e into project-codeflare:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimakis dimakis dimakis left review comments

@anishasthana anishasthana anishasthana left review comments

@Maxusmusti Maxusmusti Maxusmusti approved these changes

@Bobbins228 Bobbins228 Awaiting requested review from Bobbins228

Assignees

@anishasthana anishasthana

@Maxusmusti Maxusmusti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KPostOffice @anishasthana @Maxusmusti @dimakis