-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs for Config and Auth & update doc workflow #435
Added docs for Config and Auth & update doc workflow #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit, but other than that lgtm, great job @Bobbins228 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a couple nitpicks.
You might need to rebase as well. |
1142a44
to
309fabf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Just one comment. I think we should add a section intro
to the jobs.html file, so that all sub_modules have one. I think the ... on this page looks like something is missing, especially with the whitespace underneath.
What would you think about making these into links so it's clearer where they are coming from? Just a thought.
@Fiona-Waters |
Is it not just a matter of adding a comment here like the one included for ray jobs here? |
@Fiona-Waters My bad I thought you meant the module yeah I can add a short desc of the DDP Jobs 👍 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ed9840b
into
project-codeflare:main
Issue link
Closes #429
What changes have been made
The detailed "code orientated" docs have been moved to a new folder within docs called
detailed-docs
The release workflow has been updated to account for this.
New docs were added for Cluster Configuration and Authentication
Ingress instructions in README moved to cluster-configuration.md
Verification steps
You can verify the workflow changes by running this command.
You should get a docs/detailed-docs folder containing the detailed documentation.
Checks