Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust e2e test ClusterConfiguration min_memory #443

Merged

Conversation

ChristianZaccaria
Copy link
Collaborator

What changes have been made

If someone is using this configuration and performing get_cluster() method for fetching cluster details, they will encounter the following error:

Traceback (most recent call last):
  File "mnist_rayjob.py", line 12, in <module>
    cluster = get_cluster("mnist", namespace)
  File "/codeflare-sdk/src/codeflare_sdk/cluster/cluster.py", line 744, in get_cluster
    return Cluster.from_k8_cluster_object(
  File "/codeflare-sdk/src/codeflare_sdk/cluster/cluster.py", line 520, in from_k8_cluster_object
    min_memory=int(
ValueError: invalid literal for int() with base 10: '0.5'

The change adjusts the min_memory=1.

Verification steps

e2e tests passing is sufficient.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@VanillaSpoon
Copy link
Contributor

/lgtm :)

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, Srihari1192

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2a128da into project-codeflare:main Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants