Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ray image parameter as optional #594

Merged

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Jul 18, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-10006

What changes have been made

With the new UBI9 based ray runtime image quay.io/rhoai/ray:2.23.0-py39-cu121 used as default in codeflare-sdk raycluster-configuration, updating references of image parameter as optional in

  • ClusterConfiguration docs
  • demo-notebooks

Verification steps

  1. Clone the repository with git clone https://github.com/ChughShilpa/codeflare-sdk
  2. Checkout this PR's branch "image_parameter"
  3. Run any demo-notebooks

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
This lgtm its just we need to hold it until after release when the new SDK version includes the optional image parameter.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

@ChughShilpa ChughShilpa force-pushed the image_parameter branch 2 times, most recently from 09a6352 to e6c7594 Compare July 19, 2024 06:22
@astefanutti
Copy link
Contributor

/lgtm

@Bobbins228 if I understand your concern correctly, I think we should rather move users away from relying on the main branch, rather than holding changes?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@Bobbins228
Copy link
Contributor

@astefanutti That is a great idea!
We could have the notebooks branch which has the pre-release notebooks and when we release we can sync it with the main branch.

I did have concerns about what this current flow would be like in terms of getting source code of a specific release only to find the notebooks are outdated.

Huge +1 on this. We might need to coordinate with docs when we go through with it.

@sutaakar
Copy link
Contributor

thinking, would it have sense to reference users to use tags for sample notebooks?

@Bobbins228
Copy link
Contributor

Im happy for this to be merged after rebasing when #605 is merged

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
@astefanutti
Copy link
Contributor

/unhold

#605 has been merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
@astefanutti
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 029683f into project-codeflare:main Jul 26, 2024
10 checks passed
@ChughShilpa ChughShilpa deleted the image_parameter branch July 26, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants