Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ray to version 2.35 #666

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Fiona-Waters
Copy link
Contributor

@Fiona-Waters Fiona-Waters commented Sep 10, 2024

Issue link

RHOAIENG-12186

What changes have been made

All instances of the ray version and image have been updated to Ray 2.35 and quay.io/modh/ray:2.35.0-py39-cu121

Verification steps

  • Install RHOAI 2.14 nightly build (brew.registry.redhat.io/rh-osbs/iib:812075)
  • Run the interactive demo notebooks from this PR and enure that they work as expected.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@Fiona-Waters
Copy link
Contributor Author

@sutaakar the e2e is failing with pyproject.toml changed significantly since poetry.lock was last generated. Run poetry lock [--no-update] to fix the lock file. This command was run locally and updates were made to the poetry.lock file accordingly before creating this PR.
Would it make sense to add poetry lock --no-update here in the action?

@sutaakar
Copy link
Contributor

@Fiona-Waters hmm, do you have any idea why is it failing?

@sutaakar
Copy link
Contributor

ideally it would be good to track why there is a difference in poetry.lock

@Fiona-Waters
Copy link
Contributor Author

@Fiona-Waters hmm, do you have any idea why is it failing?

@Fiona-Waters hmm, do you have any idea why is it failing?

I ran poetry lock [--no-update] locally again, all that changed was the content-hash but that seems to have done the job. Thanks Karel :)

@Fiona-Waters Fiona-Waters marked this pull request as ready for review September 11, 2024 17:13
@Fiona-Waters Fiona-Waters changed the title [WIP] Upgrade Ray to version 2.35 Upgrade Ray to version 2.35 Sep 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call out the new images which support AMD GPUs in our docs?

docs/cluster-configuration.md Show resolved Hide resolved
@oksanabaza
Copy link
Contributor

/lgtm works as expected!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6e895a8 into project-codeflare:main Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants