-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete custom notebook image #683
base: main
Are you sure you want to change the base?
Delete custom notebook image #683
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal is awesome, thanks!
There are a couple more things which could be done in the scope of this PR:
- Remove nightly-image-build.yaml workflow.
- Update the Manual Releases section in the readme. TBH, I think we should remove that whole section and rely solely on Automated Releases.
2ac915b
to
9e32d8b
Compare
@ChristianZaccaria I don't have any strong opinion whether to remove also whole readme for manual releases. But this PR is about custom notebook image. Therefore I think to remove Readme is for different PR. |
We stoped building this image. I think we can delete it completely.
9e32d8b
to
82e336c
Compare
@jiripetrlik sounds good! The removal of the Manual Release section could be made in a separate PR. Wondering why the e2e is failing here? - I think it's unrelated, maybe it has to do with the faulty ray image being used in the SDK. There will be a fix soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We stoped building this image. I think we can delete it completely.