Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete custom notebook image #683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiripetrlik
Copy link
Contributor

We stoped building this image. I think we can delete it completely.

Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dimakis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiripetrlik jiripetrlik requested review from Bobbins228 and removed request for KPostOffice September 24, 2024 08:16
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is awesome, thanks!

There are a couple more things which could be done in the scope of this PR:

@jiripetrlik
Copy link
Contributor Author

@ChristianZaccaria
Thank you for spotting this! Both points were removed.

I don't have any strong opinion whether to remove also whole readme for manual releases. But this PR is about custom notebook image. Therefore I think to remove Readme is for different PR.

We stoped building this image. I think we can delete it completely.
@ChristianZaccaria
Copy link
Contributor

@jiripetrlik sounds good! The removal of the Manual Release section could be made in a separate PR.

Wondering why the e2e is failing here? - I think it's unrelated, maybe it has to do with the faulty ray image being used in the SDK. There will be a fix soon.

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants