Delete custom notebook image #683
Conversation
jiripetrlik
requested review from
Bobbins228
and removed request for
KPostOffice
There was a problem hiding this comment.
This removal is awesome, thanks!
There are a couple more things which could be done in the scope of this PR:
- Remove nightly-image-build.yaml workflow.
- Update the Manual Releases section in the readme. TBH, I think we should remove that whole section and rely solely on Automated Releases.
jiripetrlik
force-pushed
the
remove-custom-nb-image
branch
from
2ac915b
to
9e32d8b
Compare
|
@ChristianZaccaria I don't have any strong opinion whether to remove also whole readme for manual releases. But this PR is about custom notebook image. Therefore I think to remove Readme is for different PR. |
jiripetrlik
force-pushed
the
remove-custom-nb-image
branch
from
9e32d8b
to
82e336c
Compare
|
@jiripetrlik sounds good! The removal of the Manual Release section could be made in a separate PR. Wondering why the e2e is failing here? - I think it's unrelated, maybe it has to do with the faulty ray image being used in the SDK. There will be a fix soon. |
openshift-merge-robot
added
the
needs-rebase
We stoped building this image. I think we can delete it completely.
jiripetrlik
force-pushed
the
remove-custom-nb-image
branch
from
82e336c
to
3e856f2
Compare
openshift-merge-robot
removed
the
needs-rebase
ChristianZaccaria
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We stoped building this image. I think we can delete it completely.