Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR [merge queue] #735

Conversation

ChristianZaccaria
Copy link
Collaborator

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from christianzaccaria. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (test-odh-notebooks-sync@cda9835). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             test-odh-notebooks-sync     #735   +/-   ##
==========================================================
  Coverage                           ?   94.11%           
==========================================================
  Files                              ?       36           
  Lines                              ?     2412           
  Branches                           ?        0           
==========================================================
  Hits                               ?     2270           
  Misses                             ?      142           
  Partials                           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristianZaccaria ChristianZaccaria added this pull request to the merge queue Oct 23, 2024
Merged via the queue into project-codeflare:test-odh-notebooks-sync with commit 574bb6b Oct 23, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant