Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot labeler and workflows #740

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ updates:
ignore:
- dependency-name: "*"
update-types: ["version-update:semver-patch"]
open-pull-requests-limit: 4
open-pull-requests-limit: 1
labels:
- "dependabot"
- "test-guided-notebooks"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/dependabot-labeler.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# This workflow file adds the 'lgtm' and 'approved' labels to Dependabot PRs
# This is done to ensure that the PRs that pass e2e are automatically merged/added to merge-queues by the CodeFlare bot
# This is done to ensure that the PRs that pass required status checks are automatically merged by the CodeFlare bot
name: Dependabot Labeler

on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]
pull_request_target:
KPostOffice marked this conversation as resolved.
Show resolved Hide resolved
branches: [ main ]

jobs:
add-approve-lgtm-label:
Expand All @@ -24,4 +24,4 @@ jobs:
run: |
gh pr edit ${{ github.event.pull_request.number }} --add-label "lgtm" --add-label "approved"
env:
GITHUB_TOKEN: ${{ secrets.CODEFLARE_MACHINE_ACCOUNT_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GH_CLI_TOKEN }}
12 changes: 0 additions & 12 deletions .github/workflows/e2e_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: e2e

on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]
branches:
- main
- 'release-*'
Expand All @@ -12,16 +11,6 @@ on:
- '**.adoc'
- '**.md'
- 'LICENSE'
push:
branches:
- main
- 'release-*'
paths-ignore:
- 'docs/**'
- '**.adoc'
- '**.md'
- 'LICENSE'
merge_group:

concurrency:
group: ${{ github.head_ref }}-${{ github.workflow }}
Expand All @@ -32,7 +21,6 @@ env:

jobs:
kubernetes:
if: contains(github.event.pull_request.labels.*.name, 'e2e') || github.event_name == 'merge_group'
runs-on: ubuntu-20.04-4core-gpu

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/guided_notebook_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Guided notebooks tests

on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]
branches: [ main ]

concurrency:
group: ${{ github.head_ref }}-${{ github.workflow }}
Expand All @@ -13,7 +13,7 @@ env:

jobs:
verify-0_basic_ray:
if: contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks')
if: ${{ contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') }}
runs-on: ubuntu-20.04-4core

steps:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/pre-commit.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
name: Pre-commit
on:
push:
branches:
- '**'
tags-ignore:
- 'v*'
pull_request:
workflow_dispatch:
merge_group:

jobs:
precommit:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ui_notebooks_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: UI notebooks tests

on:
pull_request:
types: [ labeled, synchronize, opened, reopened ]
branches: [ main ]

concurrency:
group: ${{ github.head_ref }}-${{ github.workflow }}
Expand All @@ -13,7 +13,7 @@ env:

jobs:
verify-3_widget_example:
if: contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') || contains(github.event.pull_request.labels.*.name, 'test-ui-notebooks')
if: ${{ contains(github.event.pull_request.labels.*.name, 'test-guided-notebooks') || contains(github.event.pull_request.labels.*.name, 'test-ui-notebooks') }}
runs-on: ubuntu-20.04-4core

steps:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
name: Python Tests

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
merge_group:

jobs:
unit-tests:
Expand Down