Update CodeFlare operator to latest MCAD dev after every merged commit #575
Conversation
|
@anishasthana - FYI the PR for opening a CFO PR in case of any change in MCAD |
sutaakar
force-pushed
the
operator-upgrade
branch
from
d34e943
to
b86de86
Compare
| jobs: | ||
| update-codeflare-operator: | ||
| runs-on: ubuntu-latest | ||
| if: github.event.workflow_run.head_branch == 'main' |
There was a problem hiding this comment.
Should it also be checked that the workflow run was not in a fork?
There was a problem hiding this comment.
Good point, will add it
There was a problem hiding this comment.
Done, added a condition to check repository name and make sure that only successful dev image build trigger the workflow.
sutaakar
force-pushed
the
operator-upgrade
branch
from
b86de86
to
5303baa
Compare
|
/lgtm |
|
@astefanutti Do you think that I should poke someone else to review or can this be merged? |
|
@sutaakar it's been open for two weeks so I think it's good to go :) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Fixes #574
What changes have been made
After every merged commit (once
Build and Push dev MCAD image into Quayfinishes) the workflow updates MCAD dependencies in CodeFlare operator repo and open a PR with changes. The PR will then run all tests to make sure that MCAD doesn't contain any changes which could break integration between MCAD and CodeFlare operator.Verification steps
N/A
Tested locally, the result PR can be found here - project-codeflare/codeflare-operator#233
Checks