Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip completed or failed AWs after MCAD restart #669

Merged
merged 3 commits into from
Oct 20, 2023
Merged

skip completed or failed AWs after MCAD restart #669

merged 3 commits into from
Oct 20, 2023

Conversation

asm582
Copy link
Member

@asm582 asm582 commented Oct 20, 2023

Issue link

#668

What changes have been made

MCAD would skip AWs that have completed or failed.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@asm582 asm582 marked this pull request as ready for review October 20, 2023 18:05
@asm582 asm582 changed the title skip completed AWs after MCAD restart skip completed or failed AWs after MCAD restart Oct 20, 2023
metalcycling
metalcycling approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b420be0 into main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalcycling metalcycling metalcycling approved these changes

@dimakis dimakis Awaiting requested review from dimakis

Assignees

@metalcycling metalcycling

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asm582 @metalcycling