Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugger template and instructions #688

Merged

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

Closes #687

What changes have been made

Added launch.json file for local debugging of MCAD

Verification steps

Follow the instructions in the created doc to start a local debugging session with MCAD.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Manual tests

Copy link

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally and works perfectly although we could add a comment for switching the log levels.

doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
Copy link

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2023
Copy link

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristianZaccaria Thanks! very useful PR :)

doc/usage/debugger/debugger.md Outdated Show resolved Hide resolved
doc/usage/debugger/debugger.md Outdated Show resolved Hide resolved
doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
doc/usage/debugger/launch.json.template Outdated Show resolved Hide resolved
doc/usage/debugger/debugger.md Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Nov 14, 2023

@ronensc: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, Bobbins228, ronensc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 41833f2 into project-codeflare:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add launch.json template for local debugging with VSCode
4 participants