Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace special deprecated by special_id/type #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

newfrenchy83
Copy link
Contributor

No description provided.

@irydacea
Copy link
Member

This is not mergeable right now. The wiki states that special_id and special_type were introduced in 1.15.2, and IftU and AtS support 1.14.3 and later.

Additionally, wherever special=FOO was used, special_id=FOO should be used instead since my intent was never to match tag names.

@newfrenchy83
Copy link
Contributor Author

This is not mergeable right now. The wiki states that special_id and special_type were introduced in 1.15.2, and IftU and AtS support 1.14.3 and later.

Additionally, wherever special=FOO was used, special_id=FOO should be used instead since my intent was never to match tag names.

fixed

@newfrenchy83
Copy link
Contributor Author

@irydacea I replaced special = with the SPECIAL_ID macro to take into account the version of wesnoth used

@irydacea
Copy link
Member

At no point did I say that a macro wrapper was the solution. I simply don't want to waste time patching deprecation warnings for code that otherwise works just fine on both versions. Have you not seen my forum post on the matter?

https://forums.wesnoth.org/viewtopic.php?p=664724#p664724

@newfrenchy83
Copy link
Contributor Author

@irydacea now what Ats fully supported in 1.16, this PR is megeable now, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants