HTTP dynamic path segments #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexus4880
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
This is definitely a far more elegant solution than what I had written.
I rather like the usage of the constructor holding the path as the registration of the behaviour is as simple as FuyuServer.AddHttpService<FuyuBehaviour>(); instead of having the path in the function call.
I think an attribute could be looked into later. As far as adding dynamic paths I really feel like this hits the mark and should be merged.
Lacyway
previously approved these changes
Aug 31, 2024
nexus4880
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is functional and works, marked it WIP for discussion.
Inspired by #18, I implemented HTTP path arguments into
FuyuServer.Implementation differs from @nexus4880's version by not using LINQ and using multi-threading for lookup to offset the cost of segment matching.
Discussion
I'm not happy with setting
pathinsideFuyuBehaviour's constructor. Suggestions and ideas are welcome!Since
FuyuServercontains a unique identifier (FuyuServer.Name), maybe we can bindFuyuBehaviouron runtime toFuyuServerby using a new attribute[FuyuRoute(string serverName, string path)]and initialize FuyuBehaviour using it?