Red Hat Konflux update domain-proxy #2
Conversation
![red-hat-konflux[bot]](https://avatars.githubusercontent.com/in/296509?s=60&v=4){kind=small}
Signed-off-by: red-hat-konflux <[email protected]>
| RUN go mod tidy | ||
| RUN go build -o domainproxyserver cmd/server/main.go | ||
| RUN go build -o domainproxyclient cmd/client/main.go | ||
| ENV GOTOOLCHAIN=auto \ |
There was a problem hiding this comment.
What's the purpose of these two env variables?
There was a problem hiding this comment.
I've done some research and setting these two env variables appears to be redundant as they're inducing default behaviour?
There was a problem hiding this comment.
Ah, I see that go mod tidy failed in a previous run, I suppose that might necessitate the env variables depending on build environment... Never failed when building domain proxy in JBS. I wonder if the top level JBS go config prevented that.
There was a problem hiding this comment.
Yes its slightly bizarre that it didn't fail in JBS but those variables were used elsewhere in JBS so I suspect you're right and there was some subtle interaction that made it work.
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization
https://issues.redhat.com/browse/JBS-74