-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NCL-8162] Implement useForm async validations #314
base: main
Are you sure you want to change the base?
[NCL-8162] Implement useForm async validations #314
Conversation
ddc0346
to
ea49964
Compare
9506fee
to
9f55123
Compare
src/components/ProductMilestoneCreateEditPage/ProductMilestoneCreateEditPage.tsx
Outdated
Show resolved
Hide resolved
src/components/ProductMilestoneCreateEditPage/ProductMilestoneCreateEditPage.tsx
Show resolved
Hide resolved
src/components/ProductMilestoneCreateEditPage/ProductMilestoneCreateEditPage.tsx
Outdated
Show resolved
Hide resolved
src/components/ProductMilestoneCreateEditPage/ProductMilestoneCreateEditPage.tsx
Show resolved
Hide resolved
src/components/ProductMilestoneCreateEditPage/ProductMilestoneCreateEditPage.tsx
Show resolved
Hide resolved
Hi @patrikk0123 , I submitted in-progress review, some of the comments will be probably already outdated as you raised some additional changes later. |
9f55123
to
0a295e1
Compare
0a295e1
to
0409858
Compare
Hi @patrikk0123 , there are 2 unresolved questions, please can you look at them? Thanks |
c4fe3f1
to
9958f74
Compare
ef46743
to
e3ae6cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement following on demo page:
"Form Async Demo" separated box containing two fields:
- input (string is expected)
- sync validation: the value is the same as Product Version below
- async validation: random async validation
- product version field
- 2 async validations: product version validation endpoint
- related fields are:
input
We need to see once product version field
is changed, that both sync validation and async validation will be performed on the first input
For now, a combination of multifield validation and async one is not working correctly. This might be fixed in future Jira. |
We agreed to mark it as "Draft" and merge NCL-7207 first |
No description provided.