[NCL-8947] Disable restore button for last revision #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matedo1
requested changes
Dec 5, 2024
| if (!serviceContainerBuildConfig.data || !serviceContainerBuildConfigRevision.data) { | ||
| return false; | ||
| } | ||
| return serviceContainerBuildConfig.data?.modificationTime === serviceContainerBuildConfigRevision.data?.modificationTime; |
There was a problem hiding this comment.
I have two points:
-
Would it be possible to use ID based comparison instead of
modificationTimebased? We have list of all revisions available and we know the last one is the current one. -
We should try to load the last revision somewhere on the
BuildConfigRevisionPagesand share viauseOutletContext? So that no other http request is performed. Your current solution is loading new Build Config for each revision.
Using the list of revisions which is already loaded on the BuildConfigRevisionPages may not be possible because there are multiple pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.