fix(SBOMER-290): duplicated comments after release manifest generation

project-ncl · Dec 20, 2024 · 3865003 · 3865003
1 parent 4ea7cb4
commit 3865003
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...jboss/sbomer/service/feature/sbom/errata/event/release/ReleaseAdvisoryEventsListener.java b/...jboss/sbomer/service/feature/sbom/errata/event/release/ReleaseAdvisoryEventsListener.java
@@ -262,9 +262,12 @@ protected void releaseManifestsForRPMBuilds(
 
     @Transactional
     protected void doUpdateGenerationsStatus(Collection<SbomGenerationRequest> releaseGenerations) {
-        for (SbomGenerationRequest releaseGeneration : releaseGenerations) {
-            releaseGeneration = generationRequestRepository.findById(releaseGeneration.getId());
-            SbomGenerationRequest.updateRequestEventStatus(releaseGeneration);
+        // Update only one SbomGenerationRequest, because the requestEvent associated is the same for all of them. This
+        // avoids duplicated comments in the advisory
+        if (releaseGenerations != null && !releaseGenerations.isEmpty()) {
+            SbomGenerationRequest generation = releaseGenerations.iterator().next();
+            generation = generationRequestRepository.findById(generation.getId());
+            SbomGenerationRequest.updateRequestEventStatus(generation);
         }
     }