chore: update to latest Quarkus micro #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
force-pushed
the
quarkus-micros
branch
from
6d1ccf2 to
a94bbc1
Compare
While I agree you should stay compatible with the minor requested by the Operator SDK extension, I don't think it's a good idea to stay on the micro as you are missing all the fixes we are pushing since at the moment the version used here is 3.17.0. So my advice is: update to the latest micro of the minor branch requested for the Operator SDK. This is important for project-ncl#1076 as otherwise, you will have to wait a lot longer to get the fix. Also it's good practice in general.
gsmet
force-pushed
the
quarkus-micros
branch
from
a94bbc1 to
ca4b84c
Compare
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I agree you should stay compatible with the minor requested by the Operator SDK extension, I don't think it's a good idea to stay on the micro as you are missing all the fixes we are pushing since at the moment the version used here is 3.17.0.
So my advice is: update to the latest micro of the minor branch requested for the Operator SDK.
This is important for #1076 as otherwise, you will have to wait a lot longer to get the fix. Also it's good practice in general.