Introduction of GitHub actions and GitLab Pages workflow #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmann
changed the title
|
Note: this still requires implementing running e2e tests, I'll do this shortly. |
|
Support for running e2e tests was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters how we perform CI and CD. Basically this is a move out of Jenkins and make use of two other services: GitHub Actions and GitLab Pipelines.
On GH we do the build process, this includes the service and cli code as well as all images. This is run for every PR as well as every merge to
mainbranch. The difference is that when merged, these images are pushed to quay. This is where GH Actions stop.This merge event will be picked up by GitLab at some point (delay up to 5 minutes). This will start the deployment process on staging environment. Once this is done, the e2e tests will be run and if successful, a there will be a proposal to move to production. Deploying to production requires a manual approval, at least for now.