fix(SBOMER-166): do not set product coordinates to not send UMB message #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the main component (metadata/component) does not have the build information attached, because the artifact cannot be found in PNC and thus the information about the build system wasn't added to external references in the main component. This comimt stops setting the product coordinates for this specific e2e, but this is just a workaround. The proper fix will be implemented later. Related: https://issues.redhat.com/browse/SBOMER-26 Fixes: https://issues.redhat.com/browse/SBOMER-166
|
I think this makes sense because we are propagating something that we know it won't work. The fix as you say would be to take a look at Gradle components which have multimodule (this is what I think was the outstanding issue with Gradle builds with the gradle-cyclonedx-plugin). So I am fine with this temporary solution until we fix the manifesting. |
vibe13
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the main component (metadata/component) does not have the build information attached, because the artifact cannot be found in PNC and thus the information about the build system wasn't added to external references in the main component.
This comimt stops setting the product coordinates for this specific e2e, but this is just a workaround. The proper fix will be implemented later.
Related: https://issues.redhat.com/browse/SBOMER-26
Fixes: https://issues.redhat.com/browse/SBOMER-166