Update prost and fix many things #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddrysdale
force-pushed
the
bump
branch
3 times, most recently
from
8f06d36
to
13cb6ba
Compare
Mostly shifting from <Enum>::from_i32() to <Enum>::try_from()
With `export PROTOC=/usr/bin/protoc; cargo build`
With `export PROTOC=/usr/bin/protoc; cargo build The current version of `tonic-build` needs 2021 edition (because it assumes `TryInto` is in the prelude) so move to that for this crate. Mark the top-level workspace as still using resolver = 1.
conradgrobler
approved these changes
Oct 2, 2024
| @@ -23,8 +23,10 @@ ignore = [ | |||
| "RUSTSEC-2022-0071", | |||
| # ansi_term is Unmaintained (via structopt(0.3.26)). | |||
| "RUSTSEC-2021-0139", | |||
| # proc-macro-error is Unmaintained (via structopt-derive(0.4.18) | |||
| # proc-macro-error is Unmaintained (via structopt-derive(0.4.18)). | |||
There was a problem hiding this comment.
it might be worth considering clap instead of structopt if it brings in unmaintained crates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.