After ignored users list is updated, use pagination to refill the cleared timelines #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But, there are still a couple of things we need to fix up:
* saving which event ID is currently shown on each timeline,
such that we can jump back to displaying that event after the
timelines get cleared and then refilled.
* subscribing to an ignored user stream, such that we can receive
an update when the current logged-in user (un)ignores someone
from a different client that we do not control.
* See `Client::subscribe_to_ignore_user_list_changes()`:
<https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk/struct.Client.html#method.subscribe_to_ignore_user_list_changes>
This allows Robrix to be aware of the current logged-in user ignoring or unignoring a user on a different client instance, and respond to the fact that an ignore/unignore action has occurred elsewhere, i.e., *beyond* the ignore user UI flow that is driven from the UserProfileSlidingPane action buttons. As such, we move the logic for re-paginating all cleared timelines to the handler for updates to the ignored users lists.
Do not attempt to trust or use the Matrix SDK's list of ignored users, as it does not get updated properly in the current version of the SDK. We now maintain our own list, which does properly get synced when the logged-in users ignores/unignores other users on a different client or session. This includes correctly setting the `ignore_user_button`'s text.
kevinaboos
changed the title
ignore_user pagination does work to refill the cleared timeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But, there are still a couple of things we need to fix up:
Client::subscribe_to_ignore_user_list_changes(): https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk/struct.Client.html#method.subscribe_to_ignore_user_list_changesIdeally we also do not want to re-paginate all rooms, just the ones that were already (partially) paginated.