Use the user profile cache as a fallback for usernames/avatars #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this commit only adds the usage of the user profile cache for the drawing of a profile (user name + avatar) for each timeline event. Rewrite the avatar_cache to use a thread-local cache only accessible by the main UI thread (just like the user_profile_cache) instead of being based on the media cache.
|
still needs thorough testing |
* Actually handle the avatar-fetching updates from the background task. * Don't re-send redundant requests if a request to fetch an avatar was already submitted previously but has yet to be completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this commit only adds the usage of the user profile cache for the drawing of a profile (user name + avatar) for each timeline event.
Rewrite the avatar_cache to use a thread-local cache only accessible by the main UI thread (just like the user_profile_cache) instead of being based on the media cache.
Addresses #96