Reply preview improvements and reply preview click smooth scroll #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmzbl
force-pushed
the
reply-preview-improvements
branch
from
86fc350 to
882b611
Compare
fmzbl
force-pushed
the
reply-preview-improvements
branch
from
6f8f2dc to
882b611
Compare
kevinaboos
requested changes
Sep 20, 2024
which we now use for scrolling up to replies. Highlight a replied-to message upon click (after auto-scroll to it) in a light blue color, which makes it much more obvious. Explicitly specify the default font color of Html widgets.
that have not yet been fetched in the timeline
Use `Vector::focus()` with reverse iteration from the current reply message, searching backwards since the replied-to message must come before the reply message
kevinaboos
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Thanks for the PR. I made some changes to how we search for the replied-to message in the timeline, mainly just to make it a lot faster.
I found quite a few scenarios where the smooth_scroll_to() function does not work as expected. Most of them occur when the message is already visible, but at least the highlighting makes it very obvious where the message is. Sometimes it just straight up doesn't work, but since it sounds like you're already working on improving the smooth_scroll_to() function, we can go ahead and merge this and then add future improvements later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes clicking a reply preview trigger a smooth scroll to the item, which is then highlighted.