-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate the typing notification bar in and out of the RoomScreen view #179
Animate the typing notification bar in and out of the RoomScreen view #179
Conversation
@alanpoon Also, resolve the conflict. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, looks really good!
Can you also make it sliding upwards when showing it too? That way the animation is symmetric when being shown and when being hidden.
I also think it'd look nicer if the animation was a little bit faster (like 25% faster), but that's ultimately up to you.
Slideup.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks very much!
Please resolve conflicts and then I will merge it in.
…poon/robrix into typing_notice_animation#155
resolved conflict and merged main |
if is_typing { | ||
typing_animation.animate(cx); | ||
} else { | ||
typing_animation.stop_animation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fade_away.mp4
Fixed 3rd task of this issue
#155
Closes #155