Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate the typing notification bar in and out of the RoomScreen view #179

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

alanpoon
Copy link
Contributor

@alanpoon alanpoon commented Oct 9, 2024

fade_away.mp4

Fixed 3rd task of this issue
#155

Closes #155

@ZhangHanDong
Copy link
Contributor

@alanpoon
The vertical height of the notification background is a bit too large, can it be adjusted to be narrower?

Also, resolve the conflict.

@alanpoon
Copy link
Contributor Author

@alanpoon The vertical height of the notification background is a bit too large, can it be adjusted to be narrower?

Also, resolve the conflict.

Done.

Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks really good!

Can you also make it sliding upwards when showing it too? That way the animation is symmetric when being shown and when being hidden.

I also think it'd look nicer if the animation was a little bit faster (like 25% faster), but that's ultimately up to you.

@kevinaboos kevinaboos changed the title added _animation for fade away for typing_notice Animate the typing notification bar in and out of the RoomScreen view Oct 11, 2024
@alanpoon
Copy link
Contributor Author

Nice job, looks really good!

Can you also make it sliding upwards when showing it too? That way the animation is symmetric when being shown and when being hidden.

I also think it'd look nicer if the animation was a little bit faster (like 25% faster), but that's ultimately up to you.

  • Added Sliding upwards when showing.
  • Sped up the animation
  • Height of typing_notice made narrower
Slideup.mp4

kevinaboos
kevinaboos previously approved these changes Oct 30, 2024
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks very much!

Please resolve conflicts and then I will merge it in.

@alanpoon
Copy link
Contributor Author

resolved conflict and merged main

if is_typing {
typing_animation.animate(cx);
} else {
typing_animation.stop_animation();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve the typing_notice view with animations
3 participants