Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies for apt #187

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix dependencies for apt #187

merged 3 commits into from
Oct 11, 2024

Conversation

aaravlu
Copy link
Contributor

@aaravlu aaravlu commented Oct 11, 2024

llvm & clang & libclang-dev, which consumes a lot of traffic during the download, are not necessary.

aaravlu
aaravlu commented Oct 11, 2024
View reviewed changes
Copy link
Contributor Author

@aaravlu aaravlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed

kevinaboos
kevinaboos approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you're correct. Thanks for the fix!

Those were previously required when building native libraries (e.g., openssl) during the build process, but now that we use rustls we don't actually need them. Thanks!

@kevinaboos kevinaboos merged commit 25de320 into project-robius:main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinaboos kevinaboos kevinaboos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaravlu @kevinaboos