Completely redesign pagination code, support backwards pagination upon scroll #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n scroll Remove the separate pagination state subscriber task, which was previously being spawned once for every room. That was unnecessary and actually provided less information than just waiting for the result of the original task that actually called the paginate function. Store the most-recently-scrolled-through item index in `TimelineUiState` such that we can determine whether when the user is scrolling upwards and has just hit the top-most item, at which point we fire off a backwards pagination request.
Clean up various pagination code. Re-format the TopSpace (for pagination loading messages) to be a lightly-transparent green, and to be an Overlay atop the timeline such that it doesn't affect the positional stability of timeline items. Refactor RoomScreen event-handling functions to remove redundant calls to `self.portal_list(id!(timeline.list))`. We now call this once at the top of the `RoomScreen::handle_event()` in order to have a single `PortalListRef` that can be used across all the related event handling functions.
kevinaboos
force-pushed
the
redesign_pagination
branch
from
5fb23cf to
f25b9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the separate pagination state subscriber task, which was previously being spawned once for every room. That was unnecessary and actually provided less information than just waiting for the result of the original task that actually called the paginate function.
Store the most-recently-scrolled-through item index in
TimelineUiStatesuch that we can determine whether when the user is scrolling upwards and has just hit the top-most item, at which point we fire off a backwards pagination request.Closes #109