Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show JTB button with unread message badge upon new out-of-view messages #247

Conversation

kevinaboos
Copy link
Member

@kevinaboos kevinaboos commented Nov 9, 2024

When new messages are received in the currently-displayed room timeline, it can be hard for the user to tell/know when a new message has arrived. This commit provides a subtle visual cue that shows a small dot on the jump to bottom button, indicating that new unread messages have arrived beneath the current viewport range.

In the future, we'll also add a label with the exact count of unread messages below the current viewport.

Closes #131.

Supersedes #142.

When new messages are received in the currently-displayed room timeline,
it can be hard for the user to tell/know when a new message has arrived.
This commit provides a subtle visual cue that shows a small dot on the
jump to bottom button, indicating that new unread messages have arrived
beneath the current viewport range.

In the future, we'll also add a label with the exact count of unread messages
below the current viewport.
@kevinaboos kevinaboos marked this pull request as draft November 9, 2024 02:21
@kevinaboos
Copy link
Member Author

Still need to submit PRs that fix the PortalList at_end behavior, and then point this branch to those.

@kevinaboos kevinaboos marked this pull request as ready for review November 9, 2024 05:08
@kevinaboos kevinaboos merged commit 07bd92a into project-robius:main Nov 9, 2024
@kevinaboos kevinaboos deleted the show_jump_to_bottom_button_upon_new_message branch November 9, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update "jump to bottom" button visibility upon a change in timeline items
1 participant