Use rich HTML, fix avatar text, central style definitions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out message type for currently-unsupported messages (e.g., server notices)
…pported tags at all. We need it to display the raw HTML for unsupported cases rather than displaying nothing.
* HTML works for almost everything (underline/strikethrough not working) * avatars work * images work but don't shrink to fit the window properly * caching works again * central styles for text
|
Not yet ready to merge -- still needs changes to makepad itself, and to not depend on a local makepad installation. Also, if displaying a rich HTML message fails, we should display plaintext instead. |
|
Ready to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.