Cleanup after merging the UserProfileSlidingPane PR project-robius#78 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: there are still major problems with the UserProfileSlidingPane,
it doesn't work and the actual view is split in half, weirdly.
…lidingPane is not showing up
Still need to: * Make the window capture focus such that scrolling only scrolls the pane, not the background too. * Paint a transparent gray overlay atop the background content * Make the X close button show up properly * Use a rounded view and/or shadows to make the pane appear to be floating above the background content. * Fill in the data fields properly, i.e., User Name, Role in "ROOM NAME", Role info (levels) * Actually implement the button actions
Redesigned how the Avatar works to be a bit more flexible, e.g., it can now accept any username string. Avatars also store data about the user they're displaying, which enables them to be self-sufficient when handling actions like being clicked on.
kevinaboos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.